generated from linux-system-roles/template
-
Notifications
You must be signed in to change notification settings - Fork 12
ci: tox-lsr version 3.15.0 [citest_skip] #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds back support for IPv6 in qemu VMs, which appears to be working now. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr version 3.15.0 instead of 3.14.0, ensuring CI (including qemu-based integration tests) benefits from the newer tooling which restores IPv6 support in qemu VMs. Flow diagram for qemu-kvm integration tests using tox-lsr 3_15_0flowchart TD
Trigger[Push_or_PR_event] --> StartWorkflow[Start_qemu_kvm_integration_tests_workflow]
StartWorkflow --> Checkout[Checkout_repository]
Checkout --> InstallDeps[Install_tox_and_tox_lsr_3_15_0]
InstallDeps --> PrepareEnv[Prepare_test_environment]
PrepareEnv --> LaunchQemu[Launch_qemu_VMs_with_IPv4_and_IPv6]
LaunchQemu --> RunTests[Run_ansible_integration_tests_via_tox_lsr]
RunTests --> CollectResults[Collect_and_upload_test_results]
CollectResults --> Complete[Complete_workflow_status]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since the tox-lsr version string is duplicated across multiple workflows, consider centralizing it (e.g., via a reusable workflow or a single env variable) to simplify future version bumps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the tox-lsr version string is duplicated across multiple workflows, consider centralizing it (e.g., via a reusable workflow or a single env variable) to simplify future version bumps.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds back support for IPv6 in qemu VMs, which appears to be working now.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
CI: