Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 10, 2026

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Bump tox-lsr from version 3.14.0 to 3.15.0 in all GitHub Actions workflows, including qemu-kvm integration tests.

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner February 10, 2026 16:08
@richm richm self-assigned this Feb 10, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr version 3.15.0 instead of 3.14.0, ensuring CI (including qemu-based integration tests) benefits from the newer tooling which restores IPv6 support in qemu VMs.

Flow diagram for qemu-kvm integration tests using tox-lsr 3_15_0

flowchart TD
  Trigger[Push_or_PR_event] --> StartWorkflow[Start_qemu_kvm_integration_tests_workflow]
  StartWorkflow --> Checkout[Checkout_repository]
  Checkout --> InstallDeps[Install_tox_and_tox_lsr_3_15_0]
  InstallDeps --> PrepareEnv[Prepare_test_environment]
  PrepareEnv --> LaunchQemu[Launch_qemu_VMs_with_IPv4_and_IPv6]
  LaunchQemu --> RunTests[Run_ansible_integration_tests_via_tox_lsr]
  RunTests --> CollectResults[Collect_and_upload_test_results]
  CollectResults --> Complete[Complete_workflow_status]
Loading

File-Level Changes

Change Details Files
Bump tox-lsr dependency from 3.14.0 to 3.15.0 across all relevant GitHub Actions workflows.
  • Update pip install command in ansible-lint workflow to reference tox-lsr@3.15.0
  • Update pip install command in ansible-managed-var-comment workflow to reference tox-lsr@3.15.0
  • Update pip install command in ansible-test workflow to reference tox-lsr@3.15.0
  • Update pip install command in qemu-kvm-integration-tests workflow to reference tox-lsr@3.15.0
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since the tox-lsr version string is duplicated across multiple workflows, consider centralizing it (e.g., via a reusable workflow or a single env variable) to simplify future version bumps.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the tox-lsr version string is duplicated across multiple workflows, consider centralizing it (e.g., via a reusable workflow or a single env variable) to simplify future version bumps.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit b78816d into main Feb 10, 2026
11 checks passed
@richm richm deleted the tox-lsr-3.15.0 branch February 10, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant